[MNG-8403] Maven ITs use maven-executor #1940
Open
+2,229
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * dropped from ITs maven-shared-util (replaced with JDK or plexus-utils anyway present) * dropped from ITs maven-verifier, copied last master classes to maven-it-helper * enhancing maven-executor WIP
patrickkenya
approved these changes
Nov 28, 2024
As it keeps classworld alive only, and realm maven.ext and possibly other loaded extensions may want to create realms with same ID and that causes failure in ClassWorld due duplicate realm ID.
Mostly javadoc, but also change private fields to protected to be extension friendly.
As directly calling helper overrides that
cstamas
commented
Dec 4, 2024
cstamas
changed the title
|
@gnodet no, let's do it other way: remove the "shared" verifier? |
gnodet
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is manifold, but major one is to be able to use in ITs new options introduced in Maven4. Currently the "embedded" mode supports only Maven3 options, as Maven4 got new CLI entry point (CLIng), while verifier uses old MavenCli entry point, that is also deprecated. Finally, a full cleanup of (black) magic happened as well, keep ITs simple and clean.
Changes:
https://issues.apache.org/jira/browse/MNG-8403